fix: Stop polling an action attempt once the timeout passes - #572
Open
razor-x wants to merge 1 commit into
Open
Conversation
The wait loop advanced its clock only by the polling interval, so a polling_interval of zero never timed out and polled without pause, the time spent waiting on the API never counted against the timeout, and every wait overran the timeout by one interval. Poll against a monotonic deadline, sleeping the shorter of the interval and the remaining budget, so the wait still polls once when the timeout is shorter than the interval and stops as soon as the deadline passes. Reject a negative timeout and a polling interval that is not greater than zero with the SDK's invalid options error before the first poll. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQW83gyXeUG61RDrHEky97
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SDK audit finding H2.
ActionAttemptResolver.wait_until_resolvedadvanced its clock only bypolling_interval:polling_interval: 0never advanced the clock, so the timeout never fired and the loop polled/action_attempts/getwithout pause.Fix
Poll against a monotonic deadline (ported from the python fix, seamapi/python#635):
sleep([polling_interval, remaining].min), then poll, then time out only once the deadline has actually passed. A wait still polls once when thetimeoutis shorter than thepolling_interval.Seam::Http::Options::SeamInvalidOptionsError:The timeout option must not be negative, got XandThe polling_interval option must be greater than zero, got X. The checks are written as negated comparisons soNaNis rejected too.README documents the deadline behavior and the option constraints.
Tests
New
spec/seam_client/action_attempt_polling_spec.rbagainst the raw request recorder (which gained an optional responsedelay:) asserts the exact error messages, that a rejected option makes no poll request, that a short timeout still polls exactly once, and that slow responses count against the deadline.Revert-check against the previous resolver: the interval-zero spec hangs, the slow-response spec takes 1.8s against a 0.5s timeout, and the short-timeout spec sleeps the full 3s interval.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SQW83gyXeUG61RDrHEky97
Generated by Claude Code